aboutsummaryrefslogtreecommitdiff
path: root/ui-ssdiff.c
diff refs
from:
to:
flip
diff options
context:
space:
mode:
Diffstat (limited to 'ui-ssdiff.c')
-rw-r--r--ui-ssdiff.c99
1 files changed, 31 insertions, 68 deletions
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index af8bc9e..2481585 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -1,5 +1,4 @@
#include "cgit.h"
-#include "ui-ssdiff.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-diff.h"
@@ -7,7 +6,6 @@
extern int use_ssdiff;
static int current_old_line, current_new_line;
-static int **L = NULL;
struct deferred_lines {
int line_no;
@@ -18,40 +16,16 @@ struct deferred_lines {
static struct deferred_lines *deferred_old, *deferred_old_last;
static struct deferred_lines *deferred_new, *deferred_new_last;
-static void create_or_reset_lcs_table(void)
-{
- int i;
-
- if (L != NULL) {
- memset(*L, 0, sizeof(int) * MAX_SSDIFF_SIZE);
- return;
- }
-
- // xcalloc will die if we ran out of memory;
- // not very helpful for debugging
- L = (int**)xcalloc(MAX_SSDIFF_M, sizeof(int *));
- *L = (int*)xcalloc(MAX_SSDIFF_SIZE, sizeof(int));
-
- for (i = 1; i < MAX_SSDIFF_M; i++) {
- L[i] = *L + i * MAX_SSDIFF_N;
- }
-}
-
static char *longest_common_subsequence(char *A, char *B)
{
int i, j, ri;
int m = strlen(A);
int n = strlen(B);
+ int L[m + 1][n + 1];
int tmp1, tmp2;
int lcs_length;
char *result;
- // We bail if the lines are too long
- if (m >= MAX_SSDIFF_M || n >= MAX_SSDIFF_N)
- return NULL;
-
- create_or_reset_lcs_table();
-
for (i = m; i >= 0; i--) {
for (j = n; j >= 0; j--) {
if (A[i] == '\0' || B[j] == '\0') {
@@ -85,14 +59,13 @@ static char *longest_common_subsequence(char *A, char *B)
j += 1;
}
}
-
return result;
}
static int line_from_hunk(char *line, char type)
{
char *buf1, *buf2;
- int len, res;
+ int len;
buf1 = strchr(line, type);
if (buf1 == NULL)
@@ -103,8 +76,9 @@ static int line_from_hunk(char *line, char type)
return 0;
len = buf2 - buf1;
buf2 = xmalloc(len + 1);
- strlcpy(buf2, buf1, len + 1);
- res = atoi(buf2);
+ strncpy(buf2, buf1, len);
+ buf2[len] = '\0';
+ int res = atoi(buf2);
free(buf2);
return res;
}
@@ -113,11 +87,11 @@ static char *replace_tabs(char *line)
{
char *prev_buf = line;
char *cur_buf;
- size_t linelen = strlen(line);
+ int linelen = strlen(line);
int n_tabs = 0;
int i;
char *result;
- size_t result_len;
+ char *spaces = " ";
if (linelen == 0) {
result = xmalloc(1);
@@ -125,26 +99,21 @@ static char *replace_tabs(char *line)
return result;
}
- for (i = 0; i < linelen; i++) {
+ for (i = 0; i < linelen; i++)
if (line[i] == '\t')
n_tabs += 1;
- }
- result_len = linelen + n_tabs * 8;
- result = xmalloc(result_len + 1);
+ result = xmalloc(linelen + n_tabs * 8 + 1);
result[0] = '\0';
- for (;;) {
+ while (1) {
cur_buf = strchr(prev_buf, '\t');
if (!cur_buf) {
- linelen = strlen(result);
- strlcpy(&result[linelen], prev_buf, result_len - linelen + 1);
+ strcat(result, prev_buf);
break;
} else {
- linelen = strlen(result);
- strlcpy(&result[linelen], prev_buf, cur_buf - prev_buf + 1);
- linelen = strlen(result);
- memset(&result[linelen], ' ', 8 - (linelen % 8));
- result[linelen + 8 - (linelen % 8)] = '\0';
+ strcat(result, " ");
+ strncat(result, spaces, 8 - (strlen(result) % 8));
+ strncat(result, prev_buf, cur_buf - prev_buf);
}
prev_buf = cur_buf + 1;
}
@@ -209,13 +178,11 @@ static void print_part_with_lcs(char *class, char *line, char *lcs)
}
} else if (line[i] == lcs[j]) {
same = 1;
- html("</span>");
+ htmlf("</span>");
j += 1;
}
html_txt(c);
}
- if (!same)
- html("</span>");
}
static void print_ssdiff_line(char *class,
@@ -236,14 +203,12 @@ static void print_ssdiff_line(char *class,
if (old_line_no > 0) {
struct diff_filespec *old_file = cgit_get_current_old_file();
char *lineno_str = fmt("n%d", old_line_no);
- char *id_str = fmt("id=%s#%s", is_null_oid(&old_file->oid)?"HEAD":oid_to_hex(old_rev_oid), lineno_str);
- char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str);
- html("<td class='lineno'><a href='");
- html(fileurl);
- htmlf("'>%s</a>", lineno_str + 1);
+ char *id_str = fmt("%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str);
+ html("<td class='lineno'><a class='no' href='");
+ html(cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str));
+ htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
html("</td>");
htmlf("<td class='%s'>", class);
- free(fileurl);
} else if (old_line)
htmlf("<td class='lineno'></td><td class='%s'>", class);
else
@@ -259,14 +224,12 @@ static void print_ssdiff_line(char *class,
if (new_line_no > 0) {
struct diff_filespec *new_file = cgit_get_current_new_file();
char *lineno_str = fmt("n%d", new_line_no);
- char *id_str = fmt("id=%s#%s", is_null_oid(&new_file->oid)?"HEAD":oid_to_hex(new_rev_oid), lineno_str);
- char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str);
- html("<td class='lineno'><a href='");
- html(fileurl);
- htmlf("'>%s</a>", lineno_str + 1);
+ char *id_str = fmt("%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str);
+ html("<td class='lineno'><a class='no' href='");
+ html(cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str));
+ htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
html("</td>");
htmlf("<td class='%s'>", class);
- free(fileurl);
} else if (new_line)
htmlf("<td class='lineno'></td><td class='%s'>", class);
else
@@ -287,7 +250,7 @@ static void print_ssdiff_line(char *class,
free(old_line);
}
-static void print_deferred_old_lines(void)
+static void print_deferred_old_lines()
{
struct deferred_lines *iter_old, *tmp;
iter_old = deferred_old;
@@ -300,7 +263,7 @@ static void print_deferred_old_lines(void)
}
}
-static void print_deferred_new_lines(void)
+static void print_deferred_new_lines()
{
struct deferred_lines *iter_new, *tmp;
iter_new = deferred_new;
@@ -313,7 +276,7 @@ static void print_deferred_new_lines(void)
}
}
-static void print_deferred_changed_lines(void)
+static void print_deferred_changed_lines()
{
struct deferred_lines *iter_old, *iter_new, *tmp;
int n_old_lines = calc_deferred_lines(deferred_old);
@@ -348,7 +311,7 @@ static void print_deferred_changed_lines(void)
}
}
-void cgit_ssdiff_print_deferred_lines(void)
+void cgit_ssdiff_print_deferred_lines()
{
if (!deferred_old && !deferred_new)
return;
@@ -399,7 +362,7 @@ void cgit_ssdiff_line_cb(char *line, int len)
line[len - 1] = c;
}
-void cgit_ssdiff_header_begin(void)
+void cgit_ssdiff_header_begin()
{
current_old_line = -1;
current_new_line = -1;
@@ -407,12 +370,12 @@ void cgit_ssdiff_header_begin(void)
html("<tr><td class='head' colspan='4'>");
}
-void cgit_ssdiff_header_end(void)
+void cgit_ssdiff_header_end()
{
- html("</td></tr>");
+ html("</td><tr>");
}
-void cgit_ssdiff_footer(void)
+void cgit_ssdiff_footer()
{
if (deferred_old || deferred_new)
cgit_ssdiff_print_deferred_lines();
generated by cgitext v1.3.1+15 (git 2.54.0) at 2026-09-07 16:27:11 +0000