| -rw-r--r-- | cgit.c | 3 | ||||
| -rw-r--r-- | cgit.h | 5 | ||||
| -rw-r--r-- | cgitrc.5.txt | 17 | ||||
| -rw-r--r-- | shared.c | 8 | ||||
| -rwxr-xr-x | tests/setup.sh | 1 | ||||
| -rwxr-xr-x | tests/t0102-summary.sh | 6 | ||||
| -rw-r--r-- | ui-commit.c | 6 | ||||
| -rw-r--r-- | ui-repolist.c | 2 | ||||
| -rw-r--r-- | ui-snapshot.c | 2 | ||||
| -rw-r--r-- | ui-summary.c | 4 | ||||
| -rw-r--r-- | ui-tree.c | 2 |
11 files changed, 16 insertions, 40 deletions
@@ -244,8 +244,6 @@ void config_cb(const char *name, const char *value) ctx.cfg.robots = xstrdup(value); else if (!strcmp(name, "clone-prefix")) ctx.cfg.clone_prefix = xstrdup(value); - else if (!strcmp(name, "clone-url")) - ctx.cfg.clone_url = xstrdup(value); else if (!strcmp(name, "local-time")) ctx.cfg.local_time = atoi(value); else if (!prefixcmp(name, "mimetype.")) @@ -465,7 +463,6 @@ static int prepare_repo_cmd(struct cgit_context *ctx) cgit_print_docend(); return 1; } - cgit_prepare_repo_env(ctx->repo); return 0; } @@ -165,7 +165,6 @@ struct cgit_config { char *agefile; char *cache_root; char *clone_prefix; - char *clone_url; char *css; char *favicon; char *footer; @@ -320,11 +319,9 @@ extern const char *cgit_repobasename(const char *reponame); extern int cgit_parse_snapshots_mask(const char *str); -extern int cgit_open_filter(struct cgit_filter *filter); +extern int cgit_open_filter(struct cgit_filter *filter, struct cgit_repo * repo); extern int cgit_close_filter(struct cgit_filter *filter); -extern void cgit_prepare_repo_env(struct cgit_repo * repo); - extern int readfile(const char *path, char **buf, size_t *size); extern char *expand_macros(const char *txt); diff --git a/cgitrc.5.txt b/cgitrc.5.txt index 5ba8134..9a9965b 100644 --- a/cgitrc.5.txt +++ b/cgitrc.5.txt @@ -76,11 +76,6 @@ clone-prefix:: setting is only used if `repo.clone-url` is unspecified. Default value: none. -clone-url:: - Space-separated list of clone-url templates. This setting is only - used if `repo.clone-url` is unspecified. Default value: none. See - also: "MACRO EXPANSION", "FILTER API". - commit-filter:: Specifies a command which will be invoked to format commit messages. The command will get the message on its STDIN, and the STDOUT from the @@ -368,7 +363,7 @@ repo.about-filter:: repo.clone-url:: A list of space-separated urls which can be used to clone this repo. - Default value: none. See also: "MACRO EXPANSION". + Default value: none. repo.commit-filter:: Override the default commit-filter. Default value: none. See also: @@ -516,12 +511,6 @@ can be accomplished by adding the following line to /etc/cgitrc: include=/etc/cgitrc.d/$HTTP_HOST -The following options are expanded during request processing, and support -the environment variables defined in "FILTER API": - -- clone-url -- repo.clone-url - EXAMPLE CGITRC FILE ------------------- @@ -531,8 +520,8 @@ EXAMPLE CGITRC FILE cache-size=1000 -# Specify some default clone urls using macro expansion -clone-url=git://foo.org/$CGIT_REPO_URL git@foo.org:$CGIT_REPO_URL +# Specify some default clone prefixes +clone-prefix=git://example.com ssh://example.com/pub/git http://example.com/git # Specify the css url css=/css/cgit.css @@ -70,7 +70,6 @@ struct cgit_repo *cgit_add_repo(const char *url) ret->about_filter = ctx.cfg.about_filter; ret->commit_filter = ctx.cfg.commit_filter; ret->source_filter = ctx.cfg.source_filter; - ret->clone_url = ctx.cfg.clone_url; return ret; } @@ -375,8 +374,7 @@ typedef struct { char * value; } cgit_env_var; -void cgit_prepare_repo_env(struct cgit_repo * repo) -{ +static void prepare_env(struct cgit_repo * repo) { cgit_env_var env_vars[] = { { .name = "CGIT_REPO_URL", .value = repo->url }, { .name = "CGIT_REPO_NAME", .value = repo->name }, @@ -397,7 +395,7 @@ void cgit_prepare_repo_env(struct cgit_repo * repo) fprintf(stderr, warn, p->name, p->value); } -int cgit_open_filter(struct cgit_filter *filter) +int cgit_open_filter(struct cgit_filter *filter, struct cgit_repo * repo) { filter->old_stdout = chk_positive(dup(STDOUT_FILENO), @@ -408,6 +406,8 @@ int cgit_open_filter(struct cgit_filter *filter) close(filter->pipe_fh[1]); chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO), "Unable to use pipe as STDIN"); + if (repo) + prepare_env(repo); execvp(filter->cmd, filter->argv); die("Unable to exec subprocess %s: %s (%d)", filter->cmd, strerror(errno), errno); diff --git a/tests/setup.sh b/tests/setup.sh index 1e06107..b2f1169 100755 --- a/tests/setup.sh +++ b/tests/setup.sh @@ -62,7 +62,6 @@ enable-log-linecount=1 summary-log=5 summary-branches=5 summary-tags=5 -clone-url=git://example.org/\$CGIT_REPO_URL.git repo.url=foo repo.path=$PWD/trash/repos/foo/.git diff --git a/tests/t0102-summary.sh b/tests/t0102-summary.sh index f299c5a..f0b0d9a 100755 --- a/tests/t0102-summary.sh +++ b/tests/t0102-summary.sh @@ -9,9 +9,6 @@ run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' run_test 'find commit 5' 'grep -e "commit 5" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' run_test 'no tags' '! grep -e "tags" trash/tmp' -run_test 'clone-url expanded correctly' ' - grep -e "git://example.org/foo.git" trash/tmp -' run_test 'generate bar summary' 'cgit_url "bar" >trash/tmp' run_test 'no commit 45' '! grep -e "commit 45" trash/tmp' @@ -19,8 +16,5 @@ run_test 'find commit 46' 'grep -e "commit 46" trash/tmp' run_test 'find commit 50' 'grep -e "commit 50" trash/tmp' run_test 'find branch master' 'grep -e "master" trash/tmp' run_test 'no tags' '! grep -e "tags" trash/tmp' -run_test 'clone-url expanded correctly' ' - grep -e "git://example.org/bar.git" trash/tmp -' tests_done diff --git a/ui-commit.c b/ui-commit.c index 536a8e8..a69dec6 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -106,7 +106,7 @@ void cgit_print_commit(char *hex, const char *prefix) html("</table>\n"); html("<div class='commit-subject'>"); if (ctx.repo->commit_filter) - cgit_open_filter(ctx.repo->commit_filter); + cgit_open_filter(ctx.repo->commit_filter, ctx.repo); html_txt(info->subject); if (ctx.repo->commit_filter) cgit_close_filter(ctx.repo->commit_filter); @@ -114,7 +114,7 @@ void cgit_print_commit(char *hex, const char *prefix) html("</div>"); html("<div class='commit-msg'>"); if (ctx.repo->commit_filter) - cgit_open_filter(ctx.repo->commit_filter); + cgit_open_filter(ctx.repo->commit_filter, ctx.repo); html_txt(info->msg); if (ctx.repo->commit_filter) cgit_close_filter(ctx.repo->commit_filter); @@ -123,7 +123,7 @@ void cgit_print_commit(char *hex, const char *prefix) html("<div class='notes-header'>Notes</div>"); html("<div class='notes'>"); if (ctx.repo->commit_filter) - cgit_open_filter(ctx.repo->commit_filter); + cgit_open_filter(ctx.repo->commit_filter, ctx.repo); html_txt(notes.buf); if (ctx.repo->commit_filter) cgit_close_filter(ctx.repo->commit_filter); diff --git a/ui-repolist.c b/ui-repolist.c index 25c36ce..dce2eac 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -300,7 +300,7 @@ void cgit_print_site_readme() if (!ctx.cfg.root_readme) return; if (ctx.cfg.about_filter) - cgit_open_filter(ctx.cfg.about_filter); + cgit_open_filter(ctx.cfg.about_filter, NULL); html_include(ctx.cfg.root_readme); if (ctx.cfg.about_filter) cgit_close_filter(ctx.cfg.about_filter); diff --git a/ui-snapshot.c b/ui-snapshot.c index 07cc944..126779d 100644 --- a/ui-snapshot.c +++ b/ui-snapshot.c @@ -19,7 +19,7 @@ static int write_compressed_tar_archive(struct archiver_args *args,const char *f f.argv = malloc(2 * sizeof(char *)); f.argv[0] = f.cmd; f.argv[1] = NULL; - cgit_open_filter(&f); + cgit_open_filter(&f, NULL); rv = write_tar_archive(args); cgit_close_filter(&f); return rv; diff --git a/ui-summary.c b/ui-summary.c index 227ed27..1e9a1b6 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -62,7 +62,7 @@ void cgit_print_summary() NULL, NULL, 0, 0); } if (ctx.repo->clone_url) - print_urls(expand_macros(ctx.repo->clone_url), NULL); + print_urls(ctx.repo->clone_url, NULL); else if (ctx.cfg.clone_prefix) print_urls(ctx.cfg.clone_prefix, ctx.repo->url); html("</table>"); @@ -113,7 +113,7 @@ void cgit_print_repo_readme(char *path) */ html("<div id='summary'>"); if (ctx.repo->about_filter) - cgit_open_filter(ctx.repo->about_filter); + cgit_open_filter(ctx.repo->about_filter, ctx.repo); if (ref) cgit_print_file(tmp, ref); else @@ -45,7 +45,7 @@ static void print_text_buffer(const char *name, char *buf, unsigned long size) if (ctx.repo->source_filter) { html("<td class='lines'><pre><code>"); ctx.repo->source_filter->argv[1] = xstrdup(name); - cgit_open_filter(ctx.repo->source_filter); + cgit_open_filter(ctx.repo->source_filter, ctx.repo); html_raw(buf, size); cgit_close_filter(ctx.repo->source_filter); free(ctx.repo->source_filter->argv[1]); |