| -rw-r--r-- | Makefile | 23 | ||||
| -rw-r--r-- | cgit.h | 6 | ||||
| -rw-r--r-- | cmd.c | 3 | ||||
| -rw-r--r-- | parsing.c | 4 | ||||
| -rw-r--r-- | ui-log.c | 17 | ||||
| -rw-r--r-- | ui-refs.c | 37 | ||||
| -rw-r--r-- | ui-repolist.c | 4 | ||||
| -rw-r--r-- | ui-shared.c | 17 | ||||
| -rw-r--r-- | ui-snapshot.c | 94 | ||||
| -rw-r--r-- | ui-snapshot.h | 3 |
10 files changed, 68 insertions, 140 deletions
@@ -7,26 +7,6 @@ SHA1_HEADER = <openssl/sha.h> GIT_VER = 1.6.0.3 GIT_URL = http://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.bz2 -# Define NO_STRCASESTR if you don't have strcasestr. -# -# Define NEEDS_LIBICONV if linking with libc is not enough (eg. Darwin). -# - -#-include config.mak - -# -# Platform specific tweaks -# - -uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not') -uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not') -uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not') - -ifeq ($(uname_O),Cygwin) - NO_STRCASESTR = YesPlease - NEEDS_LIBICONV = YesPlease -endif - # # Let the user override the above settings. # @@ -116,9 +96,6 @@ CFLAGS += -DCGIT_CACHE_ROOT='"$(CACHE_ROOT)"' ifdef NO_ICONV CFLAGS += -DNO_ICONV endif -ifdef NO_STRCASESTR - CFLAGS += -DNO_STRCASESTR -endif cgit: $(OBJECTS) libgit $(QUIET_CC)$(CC) $(CFLAGS) $(LDFLAGS) -o cgit $(OBJECTS) $(EXTLIBS) @@ -235,5 +235,11 @@ extern const char *cgit_repobasename(const char *reponame); extern int cgit_parse_snapshots_mask(const char *str); +/* libgit.a either links against or compiles its own implementation of + * strcasestr(), and we'd like to reuse it. Simply re-declaring it + * seems to do the trick. + */ +extern char *strcasestr(const char *haystack, const char *needle); + #endif /* CGIT_H */ @@ -104,7 +104,8 @@ static void refs_fn(struct cgit_context *ctx) static void snapshot_fn(struct cgit_context *ctx) { - cgit_print_snapshot(ctx->qry.head, ctx->qry.sha1, ctx->qry.path, + cgit_print_snapshot(ctx->qry.head, ctx->qry.sha1, + cgit_repobasename(ctx->repo->url), ctx->qry.path, ctx->repo->snapshots, ctx->qry.nohead); } @@ -96,9 +96,6 @@ char *parse_user(char *t, char **name, char **email, unsigned long *date) return p; } -#ifdef NO_ICONV -#define reencode(a, b, c) -#else const char *reencode(char **txt, const char *src_enc, const char *dst_enc) { char *tmp; @@ -113,7 +110,6 @@ const char *reencode(char **txt, const char *src_enc, const char *dst_enc) } return *txt; } -#endif struct commitinfo *cgit_parse_commit(struct commit *commit) { @@ -64,31 +64,18 @@ void print_commit(struct commit *commit) cgit_free_commitinfo(info); } -static const char *disambiguate_ref(const char *ref) -{ - unsigned char sha1[20]; - const char *longref; - - longref = fmt("refs/heads/%s", ref); - if (get_sha1(longref, sha1) == 0) - return longref; - - return ref; -} void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern, char *path, int pager) { struct rev_info rev; struct commit *commit; - const char *argv[] = {NULL, NULL, NULL, NULL, NULL}; + const char *argv[] = {NULL, tip, NULL, NULL, NULL}; int argc = 2; int i, columns = 3; if (!tip) - tip = ctx.qry.head; - - argv[1] = disambiguate_ref(tip); + argv[1] = ctx.qry.head; if (grep && pattern && (!strcmp(grep, "grep") || !strcmp(grep, "author") || @@ -78,37 +78,12 @@ static int print_branch(struct refinfo *ref) static void print_tag_header() { html("<tr class='nohover'><th class='left'>Tag</th>" - "<th class='left'>Download</th>" + "<th class='left'>Reference</th>" "<th class='left'>Author</th>" "<th class='left' colspan='2'>Age</th></tr>\n"); header = 1; } -static void print_tag_downloads(const struct cgit_repo *repo, const char *ref) -{ - const struct cgit_snapshot_format* f; - char *filename; - const char *basename; - - if (!ref || strlen(ref) < 2) - return; - - basename = cgit_repobasename(repo->url); - if (prefixcmp(ref, basename) != 0) { - if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1])) - ref++; - if (isdigit(ref[0])) - ref = xstrdup(fmt("%s-%s", basename, ref)); - } - - for (f = cgit_snapshot_formats; f->suffix; f++) { - if (!(repo->snapshots & f->bit)) - continue; - filename = fmt("%s%s", ref, f->suffix); - cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename); - html(" "); - } -} static int print_tag(struct refinfo *ref) { struct tag *tag; @@ -123,10 +98,7 @@ static int print_tag(struct refinfo *ref) html("<tr><td>"); cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); html("</td><td>"); - if (ctx.repo->snapshots && (tag->tagged->type == OBJ_COMMIT)) - print_tag_downloads(ctx.repo, name); - else - cgit_object_link(tag->tagged); + cgit_object_link(tag->tagged); html("</td><td>"); if (info->tagger) html(info->tagger); @@ -140,10 +112,7 @@ static int print_tag(struct refinfo *ref) html("<tr><td>"); html_txt(name); html("</td><td>"); - if (ctx.repo->snapshots && (tag->tagged->type == OBJ_COMMIT)) - print_tag_downloads(ctx.repo, name); - else - cgit_object_link(ref->object); + cgit_object_link(ref->object); html("</td></tr>\n"); } return 0; diff --git a/ui-repolist.c b/ui-repolist.c index 87196f0..aa743bf 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -6,10 +6,6 @@ * (see COPYING for full license text) */ -/* This is needed for strcasestr to be defined by <string.h> */ -#define _GNU_SOURCE 1 -#include <string.h> - #include <time.h> #include "cgit.h" diff --git a/ui-shared.c b/ui-shared.c index 9319881..224e5f3 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -365,14 +365,11 @@ void cgit_patch_link(char *name, char *title, char *class, char *head, void cgit_object_link(struct object *obj) { - char *page, *shortrev, *fullrev, *name; + char *page, *rev, *name; - fullrev = sha1_to_hex(obj->sha1); - shortrev = xstrdup(fullrev); - shortrev[10] = '\0'; if (obj->type == OBJ_COMMIT) { - cgit_commit_link(fmt("commit %s...", shortrev), NULL, NULL, - ctx.qry.head, fullrev); + cgit_commit_link(fmt("commit %s", sha1_to_hex(obj->sha1)), NULL, NULL, + ctx.qry.head, sha1_to_hex(obj->sha1)); return; } else if (obj->type == OBJ_TREE) page = "tree"; @@ -380,8 +377,9 @@ void cgit_object_link(struct object *obj) page = "tag"; else page = "blob"; - name = fmt("%s %s...", typename(obj->type), shortrev); - reporevlink(page, name, NULL, NULL, ctx.qry.head, fullrev, NULL); + rev = sha1_to_hex(obj->sha1); + name = fmt("%s %s", typename(obj->type), rev); + reporevlink(page, name, NULL, NULL, ctx.qry.head, rev, NULL); } void cgit_print_date(time_t secs, char *format, int local_time) @@ -709,7 +707,8 @@ void cgit_print_snapshot_links(const char *repo, const char *head, continue; filename = fmt("%s-%s%s", cgit_repobasename(repo), hex, f->suffix); - cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename); + cgit_snapshot_link(filename, NULL, NULL, (char *)head, + (char *)hex, filename); html("<br/>"); } } diff --git a/ui-snapshot.c b/ui-snapshot.c index 6f09151..9c4d086 100644 --- a/ui-snapshot.c +++ b/ui-snapshot.c @@ -114,53 +114,58 @@ static int make_snapshot(const struct cgit_snapshot_format *format, return 0; } -/* Try to guess the requested revision from the requested snapshot name. - * First the format extension is stripped, e.g. "cgit-0.7.2.tar.gz" become - * "cgit-0.7.2". If this is a valid commit object name we've got a winner. - * Otherwise, if the snapshot name has a prefix matching the result from - * repo_basename(), we strip the basename and any following '-' and '_' - * characters ("cgit-0.7.2" -> "0.7.2") and check the resulting name once - * more. If this still isn't a valid commit object name, we check if pre- - * pending a 'v' to the remaining snapshot name ("0.7.2" -> "v0.7.2") gives - * us something valid. - */ -static const char *get_ref_from_filename(const char *url, const char *filename, - const struct cgit_snapshot_format *format) -{ - const char *reponame; - unsigned char sha1[20]; - char *snapshot; - - snapshot = xstrdup(filename); - snapshot[strlen(snapshot) - strlen(format->suffix)] = '\0'; - fprintf(stderr, "snapshot=%s\n", snapshot); +char *dwim_filename = NULL; +const char *dwim_refname = NULL; - if (get_sha1(snapshot, sha1) == 0) - return snapshot; - - reponame = cgit_repobasename(url); - fprintf(stderr, "reponame=%s\n", reponame); - if (prefixcmp(snapshot, reponame) == 0) { - snapshot += strlen(reponame); - while (snapshot && (*snapshot == '-' || *snapshot == '_')) - snapshot++; +static int ref_cb(const char *refname, const unsigned char *sha1, int flags, + void *cb_data) +{ + const char *r = refname; + while (r && *r) { + fprintf(stderr, " cmp %s with %s:", dwim_filename, r); + if (!strcmp(dwim_filename, r)) { + fprintf(stderr, "MATCH!\n"); + dwim_refname = refname; + return 1; + } + fprintf(stderr, "no match\n"); + if (isdigit(*r)) + break; + r++; } + return 0; +} - if (get_sha1(snapshot, sha1) == 0) - return snapshot; - - snapshot = fmt("v%s", snapshot); - if (get_sha1(snapshot, sha1) == 0) - return snapshot; - - return NULL; +/* Try to guess the requested revision by combining repo name and tag name + * and comparing this to the requested snapshot name. E.g. the requested + * snapshot is "cgit-0.7.2.tar.gz" while repo name is "cgit" and tag name + * is "v0.7.2". First, the reponame is stripped off, leaving "-0.7.2.tar.gz". + * Next, any '-' and '_' characters are stripped, leaving "0.7.2.tar.gz". + * Finally, the requested format suffix is removed and we end up with "0.7.2". + * Then we test each tag against this dwimmed filename, and for each tag + * we even try to remove any leading characters which are non-digits. I.e. + * we first compare with "v0.7.2", then with "0.7.2" and we've got a match. + */ +static const char *get_ref_from_filename(const char *url, const char *filename, + const struct cgit_snapshot_format *fmt) +{ + const char *reponame = cgit_repobasename(url); + fprintf(stderr, "reponame=%s, filename=%s\n", reponame, filename); + if (prefixcmp(filename, reponame)) + return NULL; + filename += strlen(reponame); + while (filename && (*filename == '-' || *filename == '_')) + filename++; + dwim_filename = xstrdup(filename); + dwim_filename[strlen(filename) - strlen(fmt->suffix)] = '\0'; + for_each_tag_ref(ref_cb, NULL); + return dwim_refname; } -void cgit_print_snapshot(const char *head, const char *hex, +void cgit_print_snapshot(const char *head, const char *hex, const char *prefix, const char *filename, int snapshots, int dwim) { const struct cgit_snapshot_format* f; - char *prefix = NULL; f = get_format(filename); if (!f) { @@ -173,20 +178,11 @@ void cgit_print_snapshot(const char *head, const char *hex, return; } - if (!hex && dwim) { + if (!hex && dwim) hex = get_ref_from_filename(ctx.repo->url, filename, f); - if (hex != NULL) { - prefix = xstrdup(filename); - prefix[strlen(filename) - strlen(f->suffix)] = '\0'; - } - } if (!hex) hex = head; - if (!prefix) - prefix = xstrdup(cgit_repobasename(ctx.repo->url)); - make_snapshot(f, hex, prefix, filename); - free(prefix); } diff --git a/ui-snapshot.h b/ui-snapshot.h index b6ede52..3540303 100644 --- a/ui-snapshot.h +++ b/ui-snapshot.h @@ -2,6 +2,7 @@ #define UI_SNAPSHOT_H extern void cgit_print_snapshot(const char *head, const char *hex, - const char *filename, int snapshot, int dwim); + const char *prefix, const char *filename, + int snapshot, int dwim); #endif /* UI_SNAPSHOT_H */ |