ui-ci: let a ci-filter decide whether the tab is shown

cgit cannot know whether the ref being viewed actually has a pipeline, so
the "ci" tab is offered for every ref and only reveals a missing one once
followed. Probing the ci system from cgit is not an option: the tab is
part of the page header, so it would mean a blocking request for every
page of every repository, cgit links no http client, and job pages are
usually not readable anonymously.

Add a ci filter instead, which receives the ref, whether it is a branch or
a tag, and the expanded url, and answers with its exit status. This keeps
credentials, timeouts and caching in a script, where they belong;
filters/ci-jenkins.sh demonstrates all three against Jenkins' REST API.

The verdict is memoized, so the filter runs once per request rather than
once for the tab and again for the redirect, and it governs the page as
well as the tab, so a hidden tab cannot be reached by typing the url.

Signed-off-by: Saya Andy <saya.andy@posteo.com>

1 files changed, 10 insertions, 0 deletions

diff --git a/cgit.c b/cgit.c
index c21117e..97a4180 100644
--- a/cgit.c
+++ b/cgit.c
@@ -58,6 +58,10 @@ void cgit_repo_config(struct cgit_repo *repo, const char *name, const char *valu
 		repo->homepage = strdup_first_line(value);
 	else if (!strcmp(name, "ci-url")) {
 		repo->ci_url = strdup_first_line(value);
+		/* An explicit repo.ci-url would otherwise never be used
+		 * when the more specific urls are inherited from the
+		 * global settings, so discard those.
+		 */
 		if (repo->ci_branch_url == ctx.cfg.ci_branch_url)
 			repo->ci_branch_url = NULL;
 		if (repo->ci_tag_url == ctx.cfg.ci_tag_url)
@@ -132,6 +136,8 @@ void cgit_repo_config(struct cgit_repo *repo, const char *name, const char *valu
 			repo->email_filter = cgit_new_filter(value, EMAIL);
 		else if (!strcmp(name, "owner-filter"))
 			repo->owner_filter = cgit_new_filter(value, OWNER);
+		else if (!strcmp(name, "ci-filter"))
+			repo->ci_filter = cgit_new_filter(value, CI);
 	}
 }
 
@@ -249,6 +255,8 @@ static void config_cb(const char *name, const char *value)
 		ctx.cfg.owner_filter = cgit_new_filter(value, OWNER);
 	else if (!strcmp(name, "auth-filter"))
 		ctx.cfg.auth_filter = cgit_new_filter(value, AUTH);
+	else if (!strcmp(name, "ci-filter"))
+		ctx.cfg.ci_filter = cgit_new_filter(value, CI);
 	else if (!strcmp(name, "embedded"))
 		ctx.cfg.embedded = atoi(value);
 	else if (!strcmp(name, "max-atom-items"))
@@ -859,6 +867,8 @@ static void print_repo(FILE *f, struct cgit_repo *repo)
 		cgit_fprintf_filter(repo->email_filter, f, "repo.email-filter=");
 	if (repo->owner_filter && repo->owner_filter != ctx.cfg.owner_filter)
 		cgit_fprintf_filter(repo->owner_filter, f, "repo.owner-filter=");
+	if (repo->ci_filter && repo->ci_filter != ctx.cfg.ci_filter)
+		cgit_fprintf_filter(repo->ci_filter, f, "repo.ci-filter=");
 	if (repo->snapshots != ctx.cfg.snapshots) {
 		char *tmp = build_snapshot_setting(repo->snapshots);
 		fprintf(f, "repo.snapshots=%s\n", tmp ? tmp : "");