cgitext.git/cgit.c, branch develop

logo: include svg variant for both favicon and logo

2026-08-01T06:15:38Z

The reasoning behind using svg as primary defaults is simple – at close-up it is much neater, plus svg favicon is supported since 2015 in Firefox, 2020 in Chromium, 2025 in Safari. For old browsers ico is still kept as a fallback. The svg was auto-generated using a Python script and then simplified to a path, but kept close to an original.

licensing: add author preambles where changes were done

2026-07-31T04:38:28Z

Add a copyright for changes done by me, also note in README the nature of this repo

ui-ci: let a ci-filter decide whether the tab is shown

2026-07-30T05:27:31Z

cgit cannot know whether the ref being viewed actually has a pipeline, so the "ci" tab is offered for every ref and only reveals a missing one once followed. Probing the ci system from cgit is not an option: the tab is part of the page header, so it would mean a blocking request for every page of every repository, cgit links no http client, and job pages are usually not readable anonymously. Add a ci filter instead, which receives the ref, whether it is a branch or a tag, and the expanded url, and answers with its exit status. This keeps credentials, timeouts and caching in a script, where they belong; filters/ci-jenkins.sh demonstrates all three against Jenkins' REST API. The verdict is memoized, so the filter runs once per request rather than once for the tab and again for the redirect, and it governs the page as well as the tab, so a hidden tab cannot be reached by typing the url. Signed-off-by: Saya Andy

ui-ci: add a "ci" tab which redirects to an external ci system

2026-07-30T05:26:52Z

Add a "ci" page which redirects to an external ci system for the ref being viewed, along with a tab for it in the repository header. The target is a url template, configurable globally or per repository, with separate settings for branches and tags because pipelines for the two commonly live at different locations: on a Jenkins multibranch pipeline a branch is at job//job/ while a tag is at job//view/tags/job/. $ref, $repo and $slug are substituted, $slug being the repository url with any ".git" suffix removed and slashes replaced by dashes, which is the shape job names usually take. An explicit repo.ci-url drops the branch and tag urls the repository would otherwise inherit from the global settings, as it could never take effect otherwise. The expansion is written to the Location header verbatim rather than through cgit_redirect(), which percent-encodes '?', '=' and '%' and would corrupt any url carrying a query string. An expansion containing CR or LF is refused so that it cannot smuggle in further headers. Signed-off-by: Saya Andy

cgit: don't initialize notes when there is no repository

2026-07-30T05:23:33Z

prepare_repo_env() calls load_display_notes() unconditionally, even when setup_git_directory_gently() has just reported that repo.path is not a repository. init_notes() then resolves the default notes ref and dereferences the repository's hash algorithm, which is still NULL: EXC_BAD_ACCESS (code=1, address=0x18) get_oid_basic(str="refs/notes/commits", len=18) at object-name.c:688 -> if (len == r->hash_algo->hexsz && !get_oid_hex(str, oid)) { A typo in repo.path therefore took out the request. On Linux this segfaults; on macOS nothing consumes the Mach exception, so the faulting instruction is retried forever and the worker process spins at 100% CPU instead of dying. Only load the notes once a repository has been opened. prepare_repo_cmd() reports the failure immediately afterwards, so such a request now renders "Failed to open : No such file or directory". Signed-off-by: Saya Andy

cgit: truncate all config values at the newline

2026-05-04T16:28:27Z

These would be largely invalid anyway (save, I suppose, for Linux file paths that technically can contain new lines). The actual problem is that these get printed back out into cached -- and trusted -- cgitrc files, and if the fields have newlines, the git-config way of less trusted users configuring repos on a shared system can be abused to inject newlines, which then can be used to smuggle global options (including filters, which execute code) into the cached cgitrc. So now, only ever duplicate up to the newline, when dealing with these inputs. Reported-by: Adrian Denkiewicz Signed-off-by: Jason A. Donenfeld

cgit: use strchrnul instead of open coding

2026-05-04T16:28:27Z

Signed-off-by: Jason A. Donenfeld

cgit: devirtualize repo_config

2026-05-04T16:28:27Z

There's no reason to pass around function pointers. It was never used for anything beyond one function. Signed-off-by: Jason A. Donenfeld

cgit: override die routine globally

2026-03-10T21:19:00Z

We don't get any return value from compile_grep_patterns calling compile_regexp_failed, causing the default die routine to print to stderr and then for cgit to exit ungracefully. Instead override the default die routine to show a normal error page. Perhaps compile_grep_patterns ought to change upstream to return an error. But this commit here will handle future issues as well, so perhaps not a bad idea to do anyway. Link: https://lists.zx2c4.com/pipermail/cgit/2026-March/004982.html Link: https://lists.zx2c4.com/pipermail/cgit/2026-March/004983.html Reported-by: Adrian C. Reported-by: Aiden Woodruff Signed-off-by: Jason A. Donenfeld

ui-log: allow link following to be disabled per-repo

2026-02-24T10:49:35Z

This exists for other CPU heavy operations like blame, but doesn't for the follow functionality. Add it for that. Signed-off-by: Jason A. Donenfeld